Clarify KV store naming requirements. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the provided name is used both to find the KV store using the API and in the Compute SDK to open the store, that name must be both the name of the KV store and the name of the resource-link which connects the service to it.
|
👀 |
|
You're right, although I think this was not my intent. for now I've accepted your suggestion, and also updated the README to allow you to use the fastly CLI to do the creation and linking (the README used REST APIs because these CLI commands didn't exist way back when). |
harmony7
force-pushed
the
clarify-kv-store-name
branch
from
9864dc1 to
0f9494d
Compare
harmony7
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the provided name is used both to find the KV store using the API and in the Compute SDK to open the store, that name must be both the name of the KV store and the name of the resource-link which connects the service to it.